Skip to content

Commit

Permalink
Remove todo
Browse files Browse the repository at this point in the history
  • Loading branch information
sheetalkamat committed May 7, 2024
1 parent 29ac6c1 commit 61e6641
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions src/server/editorServices.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3914,15 +3914,13 @@ export class ProjectService {
let project: ConfiguredProject | ExternalProject | undefined = this.findExternalProjectContainingOpenScriptInfo(info);
let retainProjects: ConfiguredProject[] | ConfiguredProject | undefined;
let projectForConfigFileDiag: ConfiguredProject | undefined;
let defaultConfigProjectIsCreated = false;
let sentConfigDiag: Set<ConfiguredProject> | undefined;
if (!project && this.serverMode === LanguageServiceMode.Semantic) { // Checking semantic mode is an optimization
configFileName = this.getConfigFileNameForFile(info);
if (configFileName) {
project = this.findConfiguredProjectByProjectName(configFileName);
if (!project) {
project = this.createLoadAndUpdateConfiguredProject(configFileName, `Creating possible configured project for ${info.fileName} to open`, info.fileName);
defaultConfigProjectIsCreated = true;
(sentConfigDiag ??= new Set()).add(project);
}
// Ensure project is ready to check if it contains opened script info
Expand Down Expand Up @@ -3970,10 +3968,7 @@ export class ProjectService {
// Send the event only if the project got created as part of this open request and info is part of the project
if (projectForConfigFileDiag) {
configFileName = projectForConfigFileDiag.getConfigFilePath();
// TODO:: sheetal do this irrespective?
if (projectForConfigFileDiag !== project || defaultConfigProjectIsCreated) {
configFileErrors = projectForConfigFileDiag.getAllProjectErrors();
}
configFileErrors = projectForConfigFileDiag.getAllProjectErrors();
}
else {
// Since the file isnt part of configured project, do not send config file info
Expand Down

0 comments on commit 61e6641

Please sign in to comment.