Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Overhaul detection of JSX attributes and tag names
- Loading branch information
1 parent
db9e007
commit 5bdee45
Showing
13 changed files
with
353 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /// <reference path="fourslash.ts" /> | ||
| //@Filename: file.tsx | ||
| ////interface NestedInterface { | ||
| //// Foo: NestedInterface; | ||
| //// (props: {className?: string}): any; | ||
| ////} | ||
| //// | ||
| ////declare const Foo: NestedInterface; | ||
| //// | ||
| ////function fn1() { | ||
| //// return <Foo> | ||
| //// <Foo /*1*/ | ||
| //// </Foo> | ||
| ////} | ||
| ////function fn2() { | ||
| //// return <Foo> | ||
| //// <Foo.Foo /*2*/ | ||
| //// </Foo> | ||
| ////} | ||
| ////function fn3() { | ||
| //// return <Foo> | ||
| //// <Foo.Foo cla/*3*/ | ||
| //// </Foo> | ||
| ////} | ||
| ////function fn4() { | ||
| //// return <Foo> | ||
| //// <Foo.Foo cla/*4*/ something | ||
| //// </Foo> | ||
| ////} | ||
| ////function fn5() { | ||
| //// return <Foo> | ||
| //// <Foo.Foo something /*5*/ | ||
| //// </Foo> | ||
| ////} | ||
| ////function fn6() { | ||
| //// return <Foo> | ||
| //// <Foo.Foo something cla/*6*/ | ||
| //// </Foo> | ||
| ////} | ||
| ////function fn7() { | ||
| //// return <Foo /*7*/ | ||
| ////} | ||
| ////function fn8() { | ||
| //// return <Foo cla/*8*/ | ||
| ////} | ||
| ////function fn9() { | ||
| //// return <Foo cla/*9*/ something | ||
| ////} | ||
| ////function fn10() { | ||
| //// return <Foo something /*10*/ | ||
| ////} | ||
| ////function fn11() { | ||
| //// return <Foo something cla/*11*/ | ||
| ////} | ||
|
|
||
|
|
||
| verify.completions( | ||
| { | ||
| marker: test.markers(), | ||
| includes: [ | ||
| { name: "className", insertText: 'className={$1}', isSnippet: true, sortText: completion.SortText.OptionalMember } | ||
| ], | ||
| preferences: { | ||
| jsxAttributeCompletionStyle: "braces", | ||
| includeCompletionsWithSnippetText: true, | ||
| includeCompletionsWithInsertText: true, | ||
| }, | ||
| } | ||
| ) |
68 changes: 68 additions & 0 deletions
68
tests/cases/fourslash/jsxTagNameDottedAttributeSnippetClosed.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| /// <reference path="fourslash.ts" /> | ||
| //@Filename: file.tsx | ||
| ////interface NestedInterface { | ||
| //// Foo: NestedInterface; | ||
| //// (props: {className?: string}): any; | ||
| ////} | ||
| //// | ||
| ////declare const Foo: NestedInterface; | ||
| //// | ||
| ////function fn1() { | ||
| //// return <Foo> | ||
| //// <Foo /*1*/ /> | ||
| //// </Foo> | ||
| ////} | ||
| ////function fn2() { | ||
| //// return <Foo> | ||
| //// <Foo.Foo /*2*/ /> | ||
| //// </Foo> | ||
| ////} | ||
| ////function fn3() { | ||
| //// return <Foo> | ||
| //// <Foo.Foo cla/*3*/ /> | ||
| //// </Foo> | ||
| ////} | ||
| ////function fn4() { | ||
| //// return <Foo> | ||
| //// <Foo.Foo cla/*4*/ something /> | ||
| //// </Foo> | ||
| ////} | ||
| ////function fn5() { | ||
| //// return <Foo> | ||
| //// <Foo.Foo something /*5*/ /> | ||
| //// </Foo> | ||
| ////} | ||
| ////function fn6() { | ||
| //// return <Foo> | ||
| //// <Foo.Foo something cla/*6*/ /> | ||
| //// </Foo> | ||
| ////} | ||
| ////function fn7() { | ||
| //// return <Foo /*7*/ /> | ||
| ////} | ||
| ////function fn8() { | ||
| //// return <Foo cla/*8*/ /> | ||
| ////} | ||
| ////function fn9() { | ||
| //// return <Foo cla/*9*/ something /> | ||
| ////} | ||
| ////function fn10() { | ||
| //// return <Foo something /*10*/ /> | ||
| ////} | ||
| ////function fn11() { | ||
| //// return <Foo something cla/*11*/ /> | ||
| ////} | ||
|
|
||
| verify.completions( | ||
| { | ||
| marker: test.markers(), | ||
| includes: [ | ||
| { name: "className", insertText: 'className={$1}', isSnippet: true, sortText: completion.SortText.OptionalMember } | ||
| ], | ||
| preferences: { | ||
| jsxAttributeCompletionStyle: "braces", | ||
| includeCompletionsWithSnippetText: true, | ||
| includeCompletionsWithInsertText: true, | ||
| }, | ||
| } | ||
| ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /// <reference path="fourslash.ts" /> | ||
| //@Filename: file.tsx | ||
| ////interface NestedInterface { | ||
| //// Foo: NestedInterface; | ||
| //// (props: {}): any; | ||
| ////} | ||
| //// | ||
| ////declare const Foo: NestedInterface; | ||
| //// | ||
| ////function fn1() { | ||
| //// return <Foo> | ||
| //// </*1*/ | ||
| //// </Foo> | ||
| ////} | ||
| ////function fn2() { | ||
| //// return <Foo> | ||
| //// <Fo/*2*/ | ||
| //// </Foo> | ||
| ////} | ||
| ////function fn3() { | ||
| //// return <Foo> | ||
| //// <Foo./*3*/ | ||
| //// </Foo> | ||
| ////} | ||
| ////function fn4() { | ||
| //// return <Foo> | ||
| //// <Foo.F/*4*/ | ||
| //// </Foo> | ||
| ////} | ||
| ////function fn5() { | ||
| //// return <Foo> | ||
| //// <Foo.Foo./*5*/ | ||
| //// </Foo> | ||
| ////} | ||
| ////function fn6() { | ||
| //// return <Foo> | ||
| //// <Foo.Foo.F/*6*/ | ||
| //// </Foo> | ||
| ////} | ||
|
|
||
| verify.completions( | ||
| { | ||
| marker: test.markers(), | ||
| includes: [ | ||
| { name: "Foo", insertText: undefined, isSnippet: undefined } | ||
| ], | ||
| preferences: { | ||
| jsxAttributeCompletionStyle: "braces", | ||
| includeCompletionsWithSnippetText: true, | ||
| includeCompletionsWithInsertText: true, | ||
| }, | ||
| } | ||
| ) |
Oops, something went wrong.