Skip to content

Commit

Permalink
Make more build options internal which correspond to internal compile…
Browse files Browse the repository at this point in the history
…r options

Also fix return type of readBuilderProgram
  • Loading branch information
sheetalkamat committed May 16, 2019
1 parent 138f757 commit 098c900
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 15 deletions.
2 changes: 1 addition & 1 deletion src/compiler/builder.ts
Expand Up @@ -993,7 +993,7 @@ namespace ts {
return map;
}

export function createBuildProgramUsingProgramBuildInfo(program: ProgramBuildInfo): EmitAndSemanticDiagnosticsBuilderProgram & SemanticDiagnosticsBuilderProgram {
export function createBuildProgramUsingProgramBuildInfo(program: ProgramBuildInfo): EmitAndSemanticDiagnosticsBuilderProgram {
const fileInfos = createMapFromTemplate(program.fileInfos);
const state: ReusableBuilderProgramState = {
fileInfos,
Expand Down
8 changes: 4 additions & 4 deletions src/compiler/tsbuild.ts
Expand Up @@ -163,10 +163,10 @@ namespace ts {
/*@internal*/ watch?: boolean;
/*@internal*/ help?: boolean;

preserveWatchOutput?: boolean;
listEmittedFiles?: boolean;
listFiles?: boolean;
pretty?: boolean;
/*@internal*/ preserveWatchOutput?: boolean;
/*@internal*/ listEmittedFiles?: boolean;
/*@internal*/ listFiles?: boolean;
/*@internal*/ pretty?: boolean;
incremental?: boolean;

traceResolution?: boolean;
Expand Down
6 changes: 1 addition & 5 deletions tests/baselines/reference/api/tsserverlibrary.d.ts
Expand Up @@ -4449,7 +4449,7 @@ declare namespace ts {
function createAbstractBuilder(rootNames: ReadonlyArray<string> | undefined, options: CompilerOptions | undefined, host?: CompilerHost, oldProgram?: BuilderProgram, configFileParsingDiagnostics?: ReadonlyArray<Diagnostic>, projectReferences?: ReadonlyArray<ProjectReference>): BuilderProgram;
}
declare namespace ts {
function readBuilderProgram(compilerOptions: CompilerOptions, readFile: (path: string) => string | undefined): (EmitAndSemanticDiagnosticsBuilderProgram & SemanticDiagnosticsBuilderProgram) | undefined;
function readBuilderProgram(compilerOptions: CompilerOptions, readFile: (path: string) => string | undefined): EmitAndSemanticDiagnosticsBuilderProgram | undefined;
function createIncrementalCompilerHost(options: CompilerOptions, system?: System): CompilerHost;
interface IncrementalProgramOptions<T extends BuilderProgram> {
rootNames: ReadonlyArray<string>;
Expand Down Expand Up @@ -4578,10 +4578,6 @@ declare namespace ts {
dry?: boolean;
force?: boolean;
verbose?: boolean;
preserveWatchOutput?: boolean;
listEmittedFiles?: boolean;
listFiles?: boolean;
pretty?: boolean;
incremental?: boolean;
traceResolution?: boolean;
[option: string]: CompilerOptionsValue | undefined;
Expand Down
6 changes: 1 addition & 5 deletions tests/baselines/reference/api/typescript.d.ts
Expand Up @@ -4449,7 +4449,7 @@ declare namespace ts {
function createAbstractBuilder(rootNames: ReadonlyArray<string> | undefined, options: CompilerOptions | undefined, host?: CompilerHost, oldProgram?: BuilderProgram, configFileParsingDiagnostics?: ReadonlyArray<Diagnostic>, projectReferences?: ReadonlyArray<ProjectReference>): BuilderProgram;
}
declare namespace ts {
function readBuilderProgram(compilerOptions: CompilerOptions, readFile: (path: string) => string | undefined): (EmitAndSemanticDiagnosticsBuilderProgram & SemanticDiagnosticsBuilderProgram) | undefined;
function readBuilderProgram(compilerOptions: CompilerOptions, readFile: (path: string) => string | undefined): EmitAndSemanticDiagnosticsBuilderProgram | undefined;
function createIncrementalCompilerHost(options: CompilerOptions, system?: System): CompilerHost;
interface IncrementalProgramOptions<T extends BuilderProgram> {
rootNames: ReadonlyArray<string>;
Expand Down Expand Up @@ -4578,10 +4578,6 @@ declare namespace ts {
dry?: boolean;
force?: boolean;
verbose?: boolean;
preserveWatchOutput?: boolean;
listEmittedFiles?: boolean;
listFiles?: boolean;
pretty?: boolean;
incremental?: boolean;
traceResolution?: boolean;
[option: string]: CompilerOptionsValue | undefined;
Expand Down

0 comments on commit 098c900

Please sign in to comment.