Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Promises with union types in callbacks #872

Closed
wants to merge 5 commits into from
Closed

Replace Promises with union types in callbacks #872

wants to merge 5 commits into from

Conversation

saschanaz
Copy link
Contributor

A cleanup before updating Streams types.

@saschanaz saschanaz requested a review from sandersn as a code owner June 13, 2020 16:28
sandersn
sandersn requested changes Sep 9, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm worried about this breaking callbacks that only return PromiseLike instead of Promise. Can you explain why this was PromiseLike originally? Was that incorrect? Will these be good breaks?

@saschanaz
Copy link
Contributor Author

No, it turns out that PromiseLike must be used as general thenables should also work.

@saschanaz
Copy link
Contributor Author

Some problems, will reopen soon

@saschanaz saschanaz closed this Sep 9, 2020
@saschanaz saschanaz reopened this Sep 9, 2020
@saschanaz saschanaz marked this pull request as draft September 9, 2020 16:16
@saschanaz saschanaz marked this pull request as ready for review September 9, 2020 16:18
@saschanaz
Copy link
Contributor Author

Never mind, my confusion 👀

@sandersn
Copy link
Member

The diff looks OK now, just need to get the build passing

@saschanaz
Copy link
Contributor Author

@sandersn That's #903, it needs some love.

@saschanaz
Copy link
Contributor Author

Replaced by #1034

@saschanaz saschanaz closed this Jul 2, 2021
@saschanaz saschanaz deleted the callback-promise branch July 2, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn Awaiting requested review from sandersn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saschanaz @sandersn