Fix validation against dataclasses #212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #201 and #208, I switched us over from using Pydantic's
validate_json
tovalidate_python
. However, there's a subtlety. From the docs:That might sound surprising if you don't catch what happens at each step. The subtlety here is that by the time data is loaded up from
json.loads
, it comes in as adict
. Understrict=True
, thatdict
is not compatible with any type other than certain kinds ofdict
s andTypedDict
s. SoPydantic already has issues at pydantic/pydantic-core#712 and pydantic/pydantic#9009 to enable the same flexibilities that
validate_json
has, but for now the recommended workaround is to reserialize and usevalidate_json
.