Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin sphinx to 1.7.9 until type error resolved #1267

Merged
merged 3 commits into from
Sep 14, 2018
Merged

pin sphinx to 1.7.9 until type error resolved #1267

merged 3 commits into from
Sep 14, 2018

Conversation

jenshnielsen
Copy link
Collaborator

No description provided.

@jenshnielsen jenshnielsen changed the title pin sphinx to 1.7.8 until type error resolved pin sphinx to 1.7.9 until type error resolved Sep 13, 2018
@jenshnielsen
Copy link
Collaborator Author

Workaround for #1268

WilliamHPNielsen
WilliamHPNielsen approved these changes Sep 13, 2018
View reviewed changes
Copy link
Contributor

@WilliamHPNielsen WilliamHPNielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamHPNielsen WilliamHPNielsen merged commit 3a57cc7 into microsoft:master Sep 14, 2018
giulioungaretti pushed a commit that referenced this pull request Sep 14, 2018
Generated gh-pages for commit 3a57cc7
c774c71 
Merge: 4dde71c 6181996
Author: William H.P. Nielsen <whpn@mailbox.org>

    Merge pull request #1267 from jenshnielsen/pin_sphinx
@jenshnielsen jenshnielsen deleted the pin_sphinx branch November 6, 2018 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

@WilliamHPNielsen WilliamHPNielsen WilliamHPNielsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jenshnielsen @astafan8 @WilliamHPNielsen @Dominik-Vogel