Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-package] prefix is_numpy_1d_array with _ #5520

Merged
merged 2 commits into from
Oct 7, 2022
Merged

[python-package] prefix is_numpy_1d_array with _ #5520

merged 2 commits into from
Oct 7, 2022

Conversation

Madnex
Copy link
Contributor

@Madnex Madnex commented Oct 3, 2022

Contributes to #5313

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to LightGBM!

The CI failures are not something you need to worry about. We are currently working through some instability in the project's CI (see #5510) and will come back to merge this after those are resolved. Sorry for the inconvenience.

@jameslamb
Copy link
Collaborator

@Madnex ok, the project's CI issues have been fixed (#5510).

Sorry for the inconvenience, but can you please merge the latest changes from master into this branch? If CI succeeds after that, we'll merge this.

Thanks again for contributing to LightGBM!

@Madnex
Copy link
Contributor Author

Madnex commented Oct 7, 2022

Thanks! I merged it 👍

@jameslamb jameslamb merged commit 3eb68e8 into microsoft:master Oct 7, 2022
@jameslamb
Copy link
Collaborator

Thanks again for this!

@Madnex in the future, I strongly recommend that you create a branch on your fork, instead of committing directly to master and then opening a pull request from there.

Now that I've merged this, your master will have commits on it that aren't on LightGBM's master here, and vice versa.

If you want to keep contributing (and I hope you do!), the easiest way to fix that is probably just to:

  • delete your fork of LightGBM
  • re-fork LightGBM
  • submit all future pull requests from a branch that you cut off of master, like this
git clone --recursive https://github.com/Madnex/LightGBM.git
cd LightGBM
git checkout -b some-feature

👋 cheers and have a good weekend!

@Madnex
Copy link
Contributor Author

Madnex commented Oct 10, 2022

Thanks for the tipp @jameslamb ! Will do and prepare the next PR :)

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants