Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] prefer CPython in Windows test environment and use safer approach for cleaning up network (fixes #5509) #5510

Merged
merged 33 commits into from
Oct 7, 2022
Merged

[ci] prefer CPython in Windows test environment and use safer approach for cleaning up network (fixes #5509) #5510

merged 33 commits into from
Oct 7, 2022

Commits on Sep 27, 2022

  1. [ci] avoid updating dependencies when installing plotting dependencies

    @jameslamb
    jameslamb committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    1660982 View commit details
    Browse the repository at this point in the history

  2. comment out CI

    @jameslamb
    jameslamb committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    704aea4 View commit details
    Browse the repository at this point in the history

  3. explicitly pin to cpython

    @jameslamb
    jameslamb committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    b77d123 View commit details
    Browse the repository at this point in the history

  4. Revert "comment out CI" 

    This reverts commit 704aea4.
    @jameslamb
    jameslamb committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    982f07e View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. use new cluster for each dask test

    @shiyu1994
    shiyu1994 committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    7ff172d View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Revert "use new cluster for each dask test" 

    This reverts commit 7ff172d.
    @jameslamb
    jameslamb committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    f7ccfbe View commit details
    Browse the repository at this point in the history

  2. run free_network()

    @jameslamb
    jameslamb committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    da2b173 View commit details
    Browse the repository at this point in the history

  3. avoid calling free_network() during Dask teardown

    @jameslamb
    jameslamb committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    c37bb19 View commit details
    Browse the repository at this point in the history

  4. try sleeping to allow all fit() processes to finish (just for debugging)

    @jameslamb
    jameslamb committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    110ed59 View commit details
    Browse the repository at this point in the history

  5. get more logs

    @jameslamb
    jameslamb committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    d648a15 View commit details
    Browse the repository at this point in the history

  6. even more logs

    @jameslamb
    jameslamb committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    3ec3902 View commit details
    Browse the repository at this point in the history

  7. only run the Dask tests

    @jameslamb
    jameslamb committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    9c9b2c9 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. more debugging

    @jameslamb
    jameslamb committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    0cb46cb View commit details
    Browse the repository at this point in the history

  2. shorter timeout

    @jameslamb
    jameslamb committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    713739a View commit details
    Browse the repository at this point in the history

  3. add free_network() back

    @jameslamb
    jameslamb committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    3bb0b12 View commit details
    Browse the repository at this point in the history

  4. put timeout in a variable

    @jameslamb
    jameslamb committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    3cbcaee View commit details
    Browse the repository at this point in the history

  5. use a variable and skip one test that seems problematic

    @jameslamb
    jameslamb committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    01203ec View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. comment out another test

    @jameslamb
    jameslamb committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    57e0b3e View commit details
    Browse the repository at this point in the history

  2. cannot access booster_ if model isnt fitted yet

    @jameslamb
    jameslamb committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    3db4742 View commit details
    Browse the repository at this point in the history

  3. fix attribute access

    @jameslamb
    jameslamb committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    dfddc73 View commit details
    Browse the repository at this point in the history

  4. revert time_out changes

    @jameslamb
    jameslamb committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    0fad5b9 View commit details
    Browse the repository at this point in the history

  5. revert all timeout-related changes and some test.sh logging

    @jameslamb
    jameslamb committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    c8684ff View commit details
    Browse the repository at this point in the history

  6. revert garbage collection

    @jameslamb
    jameslamb committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    656a2b9 View commit details
    Browse the repository at this point in the history

  7. try a much shorter socket time_out for problematic test

    @jameslamb
    jameslamb committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    73eba73 View commit details
    Browse the repository at this point in the history

  8. try removing other skip

    @jameslamb
    jameslamb committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    d4be593 View commit details
    Browse the repository at this point in the history

  9. check if the issue is in closing the cluster

    @jameslamb
    jameslamb committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    3972fdb View commit details
    Browse the repository at this point in the history

  10. maybe print debugging will save us

    @jameslamb
    jameslamb committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    a52fde3 View commit details
    Browse the repository at this point in the history

  11. maybe the cluster is left in a weird state by the tests that raise er… 

    …rors
    @jameslamb
    jameslamb committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    a10c917 View commit details
    Browse the repository at this point in the history

  12. time out faster

    @jameslamb
    jameslamb committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    07a349b View commit details
    Browse the repository at this point in the history

  13. maybe which client you use matters

    @jameslamb
    jameslamb committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    e6a3319 View commit details
    Browse the repository at this point in the history

  14. remove remaining workarounds, uncomment CI, skip one problematic test

    @jameslamb
    jameslamb committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    00d423e View commit details
    Browse the repository at this point in the history

  15. revert a few more unnecessary changes

    @jameslamb
    jameslamb committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    2284729 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. try removing timeout on test_machines_should_be_used_if_provided()

    @jameslamb
    jameslamb committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    82fe5ef View commit details
    Browse the repository at this point in the history