Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Install matplotlib and graphviz when creating conda env #5509

Closed
wants to merge 1 commit into from

Conversation

shiyu1994
Copy link
Collaborator

This is trying to solve #5507.

@jameslamb
Copy link
Collaborator

ha oh! Didn't know you were also working on this. I just opened #5510 with an alternative approach that I hope might be a bit more future-proof than re-ordering when we install things.

Let's see which one works 😬

@shiyu1994
Copy link
Collaborator Author

@jameslamb Thanks. I think both solutions are okay as long as they work. I can close this one if you feel that #5510 is a better solution.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do feel like #5510 might be a more permanent solution to this...but I'm approving this since it's building successfully for now. That way, you can merge this to unblock CI and work on other things (since it's late for me here in the U.S. and I'm about to go to sleep).

I'll probably continue experimenting with #5510 more this week.

Thanks for working on this!

@shiyu1994
Copy link
Collaborator Author

Thanks. But it seems that Windows bdist build fails now with Azure DevOps. Not sure if it is related to this change. Will restart the tests to check.

@shiyu1994 shiyu1994 closed this Sep 27, 2022
@shiyu1994 shiyu1994 reopened this Sep 27, 2022
@jameslamb
Copy link
Collaborator

I just pushed a change over in #5510 that I think could be a permanent fix. Learned today that it's possible to include build tags in the environment description for conda, so for example you can do

conda install 'python=3.7.12[build=*cpython]`

@shiyu1994
Copy link
Collaborator Author

Close with a replacing solution in #5510.

@shiyu1994 shiyu1994 closed this Sep 29, 2022
@shiyu1994 shiyu1994 deleted the ci/fix-appveyor branch September 29, 2022 09:21
jameslamb added a commit that referenced this pull request Oct 7, 2022
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
jameslamb added a commit that referenced this pull request Dec 6, 2022
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot removed the blocking label Nov 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants