Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] replace fobj with custom objective in test comments and make tests stricter #5173

Merged
merged 2 commits into from
Apr 24, 2022

Conversation

StrikerRUS
Copy link
Collaborator

@StrikerRUS StrikerRUS commented Apr 23, 2022

Linking #5052.
More strict tests can help to spot some bugs or inconsistencies between different LightGBM versions like #4630 (comment).

@StrikerRUS StrikerRUS marked this pull request as ready for review April 23, 2022 02:10
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally agree, thanks very much for this!

@StrikerRUS StrikerRUS merged commit 56ccea4 into master Apr 24, 2022
@StrikerRUS StrikerRUS deleted the fobj_tests branch April 24, 2022 16:20
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants