Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] use lee-dohm/no-response to close stale issues (fixes #5060) #5120

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

jameslamb
Copy link
Collaborator

Fixes #5060.

See #5060 for details...the bot that LightGBM currently uses to close stale issues (https://github.com/probot/no-response) was archived by its maintainer in July 2021. That maintainer recommends switching to https://github.com/lee-dohm/no-response.

This PR proposes that change.

Notes for Reviews

The proposed change would use GitHub Actions to handle this task.

LightGBM's existing solution for this, probot/no-response, is instead a GitHub App, which I think means it had to be enabled at https://github.com/microsoft/LightGBM/settings/installations.

If this PR is approved and merged, @shiyu1994 we'll need you to remove the no-response bot from the repo's settings. I don't have permission to do that.

noResponse:
runs-on: ubuntu-latest
steps:
- uses: lee-dohm/no-response@v0.5.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! However, this action looks abandoned as well: last commit was 21 Oct 2021.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And our current no response bot was archived on on 13 Jul 2021:
probot/no-response@74cbc53

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one we currently use, probot/noresponse is explicitly archived, so I'm 100% confident it won't be receiving future updates and that it should be replaced.

I don't think lee-dohm/no-response not having a commit since October 2021 means it is "abandoned". That action is very simple, so I just don't think it requires much active development.

Consider the official "checkout" action, managed directly by GitHub: https://github.com/actions/checkout/commits/main. Even that very popular action, which is used across MANY repos (https://github.com/search?l=YAML&q=%22uses%3A+actions%2Fcheckout%22&type=Code), went 4 months (November 2021 to February 2022) without any commits.

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the investigation!
I just thought that it's possible to find a more actively developing and popular action (the proposed one has only 15 stars). But I haven't managed to find the alternative.

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jameslamb
Copy link
Collaborator Author

alright, let's see how it works!

@shiyu1994 can you please remove the no-response bot at https://github.com/microsoft/LightGBM/settings/installations?

@jameslamb jameslamb merged commit 3fd2913 into master Apr 6, 2022
@jameslamb jameslamb deleted the ci/response-bot branch April 6, 2022 00:42
@shiyu1994
Copy link
Collaborator

@jameslamb Seems that I don't have the permission to operate that either.
image
I did not see an uninstall button.
According to
https://github.community/t/how-to-remove-a-github-app/127567
It seems that we should operate from the organization side?
image

But I don't have the permission to change the settings of the organization.

It is weird that we cannot operate on this. Did I miss something?

@jameslamb
Copy link
Collaborator Author

Oh interesting! I'm not sure, maybe @guolinke will remember from when this was set up originally in #2843. I don't even have the access to see that list you've shared, so I'm just guessing at how this works 😬

@guolinke
Copy link
Collaborator

I cannot open the https://github.com/microsoft/LightGBM/settings/installations , @shiyu1994 it seems you didn't join your GitHub account to Microsoft organization, maybe you need to join to change the setting.

@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ci] switch to a supported no-response bot
4 participants