[R-package] remove behavior where lightgbm() saves model to disk #4974
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #4968
The
lightgbm()
function defaults towards dumping the model to disk in a file namedlightgbm.model
. After the last series of changes to the serialization logic, this is perhaps not a reasonable default anymore, since now model objects can be serialized natively and will for example survive session restarts in RStudio and similar, so a user fitting a model would not be prone to inadvertently lose it nor need to use this format for model serialization, thus decreasing the need for having a file in disk.Among modeling packages, it is rather uncommon to produce a file in disk by default - off the top of my head, the only such R libraries that I can think of are
xgboost
andcatboost
, while most other packages (which rely on Rds for serialization) do not even have the option of dumping in the function call.