-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] suppress warning about empty 'compute' directory and fix Rtools installation #3277
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
cc1285b
[R-package] suppress warning about empty 'compute' directory
jameslamb 8c6670e
Merge branch 'master' into fix/build-r-warning
jameslamb 4a641c6
get more logs from Rtools install
jameslamb 2bc2b33
Merge branch 'fix/build-r-warning' of github.com:jameslamb/LightGBM i…
jameslamb c7ac7c6
empty commit
jameslamb d5196a3
add a timeout
jameslamb a69526d
trying Invoke-WebRequest instead
jameslamb 7c5cd6d
Merge branch 'master' into fix/build-r-warning
jameslamb c579bd0
switch to CRAN link
jameslamb f817fb0
do not use Start-Process
jameslamb ad892b7
relative paths
jameslamb 7d02be6
trying suppressmessageboxes
jameslamb 92d74d3
Merge branch 'master' into fix/build-r-warning
jameslamb 8308596
switch strategy for running Rtools
jameslamb ac6e543
Update requirements_rtd.txt
StrikerRUS 75ccb1e
Update requirements_base.txt
StrikerRUS 3c688cd
Merge pull request #34 from StrikerRUS/StrikerRUS-patch-1
jameslamb File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
sphinx | ||
sphinx < 3.2 | ||
sphinx_rtd_theme >= 0.3 | ||
mock; python_version < '3' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
sphinx >= 3.0.2 | ||
sphinx >= 3.0.2,<3.2 | ||
sphinx_rtd_theme >= 0.3 | ||
mock; python_version < '3' | ||
breathe |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need it in the
master
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not? What is the problem with including it?
The default is 6 hours, which is way longer than these jobs need
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are dozens of config params. Including them all will make our file less readable. I believe we should keep configs as much clean and short as it is possible. Normally, our jobs don't need neither 1 hour nor 6 hours. So I don't see any differences why we should change this param from 360 to 60. Pending status more than 20 mins already indicates that something is wrong with our builds (for the current number of tests).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I respectully disagree but it is not worth holding up this blocking PR. GitHub won't allow me to commit this suggestion in the browser, but I'll commit it in a few hours when I am home.