Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] switch to a supported no-response bot #5060

Closed
jameslamb opened this issue Mar 9, 2022 · 6 comments · Fixed by #5120
Closed

[ci] switch to a supported no-response bot #5060

jameslamb opened this issue Mar 9, 2022 · 6 comments · Fixed by #5120

Comments

@jameslamb
Copy link
Collaborator

Description

This project uses probot/no-response to automatically close issues where the original poster has stops interacting with the issue.

I noticed today that that project is no longer supported.

As of July 2021, the README at https://github.com/probot/no-response reads as follows:

⚠️ We no longer recommend using this app
Use the action instead: https://github.com/lee-dohm/no-response

This project should switch to https://github.com/lee-dohm/no-response, to limit the risk of this useful automation failing due to incompatibilities with future GitHub Actions changes.

Additional Comments

Noticed this while considering a contribution to dask/community#60 and reading the discussion there.

jameslamb added a commit that referenced this issue Apr 6, 2022
)

* [ci] use lee-dohm/no-response to close stale issues (fixes #5060)

* only run once a day
@jameslamb jameslamb reopened this Apr 7, 2022
@jameslamb
Copy link
Collaborator Author

Just re-opening to discuss one more thing.

I just saw this comment posted by the new action: #5039 (comment)

  1. 🎉 this is great, it works!
  2. ...but I didn't realize that it would post as @guolinke , I think because the GitHub token used for this project's automation is tied to your account. @guolinke are you ok with this action posting those comments as you? If not, maybe @shiyu1994 could identify or create a service user (i.e. bot account) in Microsoft's GitHub organization.

@guolinke
Copy link
Collaborator

guolinke commented Apr 8, 2022

@jameslamb It is okay for me, but bot account is better.

@StrikerRUS
Copy link
Collaborator

@jameslamb

According to the https://github.com/lee-dohm/no-response#inputs,

token — Token used to access repo information. The default GitHub Actions token is sufficient.

Docs: https://docs.github.com/en/actions/security-guides/automatic-token-authentication

We just need to replace ${{ secrets.WORKFLOW }} with ${{ github.token }} here

token: ${{ secrets.WORKFLOW }}

and closing comment will be posted by github-actions [bot] account.

Example:
https://github.com/10up/ElasticPress/blob/ffb8eb61b915e73a9d0cdab87a14c262cdf36068/.github/workflows/no-response.yml#L20
10up/ElasticPress#2674 (comment)

@jameslamb
Copy link
Collaborator Author

oh excellent find @StrikerRUS , thanks!!

Ok great, I'll put up a PR with that change. Then people won't respond to those comments by tagging @guolinke 😂

@jameslamb
Copy link
Collaborator Author

Closed by #5136.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants