Remove unnecessary check from size_bytes() #1105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
size_bytes()
returns the span's size in bytes.Assuming the span was constructed with an accurate size parameter, the check
size() < dynamic_extent / sizeof(element_type)
isn't required, sincesize_t(-1)
(which isdynamic_extent
) represents the size of the address space, so the number of bytes will never exceed it and in practice won't even come close.Otherwise, it is not actually feasible to detect cases when the size parameter does not correspond to the dimensions of the underlying data pointer. In these cases, the relationship
size() < dynamic_extent / sizeof(element_type)
is simply one of many ways in which thesize()
could be incorrect, and serves no necessary purpose.Resolves #1012