Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gsl/narrow should include <exception> #1044

Merged
merged 1 commit into from Apr 26, 2022
Merged

gsl/narrow should include <exception> #1044

merged 1 commit into from Apr 26, 2022

Commits on Apr 25, 2022

  1. gsl/narrow should include <exception> 

    This file uses std::exception, so it should include the appropriate header.

Normally it gets the STL's <exception> header included via the gsl/assert file, but this is skipped with _HAS_EXCEPTIONS=0. I understand _HAS_EXCEPTIONS is undocumented and unsupported, but regardless, the appropriate header should be included here.

Alternatively, gsl/narrow should be modified to support _HAS_EXCEPTIONS=0, like gsl/assert was. But I'm not proposing that change. <exception> does define std::exception even with _HAS_EXCEPTIONS=0.
    @TheJCAB
    TheJCAB committed Apr 25, 2022
    Copy the full SHA
    8a0b66d View commit details
    Browse the repository at this point in the history