New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable per message deflate on server #8314
Merged
pradeepvairamani
merged 28 commits into
microsoft:main
from
pradeepvairamani:prrajen/perMessageDeflate
Nov 18, 2021
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
b5b50b6
Do not give SummaryWrite scope to clients that are not summarizers
pradeepvairamani f0b8a83
Merge branch 'microsoft:main' into main
pradeepvairamani bce9f61
Merge remote-tracking branch 'upstream/main'
pradeepvairamani 0de1116
Merge branch 'main' of github.com:pradeepvairamani/FluidFramework
pradeepvairamani d72f0a8
Merge remote-tracking branch 'upstream/main'
pradeepvairamani 69a6e6c
Merge remote-tracking branch 'upstream/main'
pradeepvairamani 1d056c8
Deli lumberjack logs
pradeepvairamani f0336bc
Merge branch 'microsoft:main' into main
pradeepvairamani a4a1352
Merge remote-tracking branch 'upstream/main'
pradeepvairamani b48f8a9
Merge branch 'main' of github.com:pradeepvairamani/FluidFramework
pradeepvairamani b11b1dc
Merge remote-tracking branch 'upstream/main'
pradeepvairamani 05e9e60
Merge remote-tracking branch 'upstream/main'
pradeepvairamani a047b8a
Merge remote-tracking branch 'upstream/main'
pradeepvairamani 6ad8dc3
Merge remote-tracking branch 'upstream/main'
pradeepvairamani beb0fc6
Merge remote-tracking branch 'upstream/main'
pradeepvairamani 0e78ccd
Merge remote-tracking branch 'upstream/main'
pradeepvairamani 38b6b21
Merge remote-tracking branch 'upstream/main'
pradeepvairamani ce21c8b
Merge remote-tracking branch 'upstream/main'
pradeepvairamani dd28a73
Merge remote-tracking branch 'upstream/main'
pradeepvairamani e7747ab
Merge remote-tracking branch 'upstream/main'
pradeepvairamani 6de6b09
Merge remote-tracking branch 'upstream/main'
pradeepvairamani baff178
Merge remote-tracking branch 'upstream/main'
pradeepvairamani c6fe460
Merge remote-tracking branch 'upstream/main'
pradeepvairamani 2e1e3d4
Merge remote-tracking branch 'upstream/main'
pradeepvairamani 6ac283c
Merge remote-tracking branch 'upstream/main'
pradeepvairamani f7aeb98
Merge remote-tracking branch 'upstream/main'
pradeepvairamani 3e73532
Merge remote-tracking branch 'upstream/main'
pradeepvairamani db3e80e
Enable permessage deflate flag
pradeepvairamani File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible that this setting can cause a spike in memory as we suspected last time we turned it off? If yes, do we want to make it configurable through config.json, so it's easier to disable that if needed during an emergency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same concern. There can be a CPU and memory spike (gorilla/websocket#203).
@GaryWilber Does push enable it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I saw Henrique's comment after merging the code. Will add the config as he suggested. Push is not enabling it because AFD does not support this extension. With respect to the memory and cpu consumption, pasting the offline conversation I had with Henrique: