Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make e2e test with local server run in parallel #5198

Merged
merged 2 commits into from
Feb 20, 2021

Conversation

curtisman
Copy link
Member

Also fix a test in deRehydrateContainerTests.spec.ts that register the wrong deltaManager for the OpProcessingController.

@@ -26,10 +26,11 @@
"start:tinylicious:test": "tinylicious > tinylicious.log 2>&1",
"test": "npm run test:realsvc",
"test:realsvc": "npm run test:realsvc:local && npm run test:realsvc:tinylicious",
"test:realsvc:local": "mocha dist/test --config src/test/.mocharc.js",
"test:realsvc:local": "cross-env FLUID_TEST_DRIVER= npm run test:realsvc:run -- --parallel",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed setting the environment variable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It clears it on purpose.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I think we accept "local" too.... so that might be less confusing. I will change it.

@curtisman
Copy link
Member Author

Unfortunately, mocha-junit-reporter isn't compatible with --parallel yet.
michaelleeallen/mocha-junit-reporter#140

@curtisman curtisman closed this Feb 19, 2021
@curtisman curtisman reopened this Feb 19, 2021
@curtisman
Copy link
Member Author

@tylerbutler just FYI, I have changed it to only enable if dev box for now.

@curtisman curtisman merged commit ffa283c into microsoft:main Feb 20, 2021
@curtisman curtisman deleted the par branch February 20, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants