Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error if snapshot response is empty #21068

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

jatgarg
Copy link
Contributor

@jatgarg jatgarg commented May 13, 2024

Description

Throw error if snapshot response is empty from the browser.

@jatgarg jatgarg self-assigned this May 13, 2024
@jatgarg jatgarg requested a review from vladsud May 13, 2024 23:45
@github-actions github-actions bot added area: driver Driver related issues area: odsp-driver base: main PRs targeted against main branch labels May 13, 2024
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +576 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 454.95 KB 454.95 KB No change
azureClient.js 552.06 KB 552.06 KB No change
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 258.8 KB 258.8 KB No change
fluidFramework.js 357.54 KB 357.54 KB No change
loader.js 132.78 KB 132.78 KB No change
map.js 41.45 KB 41.45 KB No change
matrix.js 143.67 KB 143.67 KB No change
odspClient.js 520.4 KB 520.6 KB +200 Bytes
odspDriver.js 97.1 KB 97.29 KB +196 Bytes
odspPrefetchSnapshot.js 41.98 KB 42.15 KB +180 Bytes
sharedString.js 160.19 KB 160.19 KB No change
sharedTree.js 357.53 KB 357.53 KB No change
Total Size 3.19 MB 3.2 MB +576 Bytes

Baseline commit: f8a24df

Generated by 🚫 dangerJS against a33b5f7

@jatgarg jatgarg merged commit 6751230 into microsoft:main May 14, 2024
30 checks passed
@jatgarg jatgarg deleted the parsing branch May 16, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: driver Driver related issues area: odsp-driver base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants