refactor(tree): Enable explicit return type rule and fix violations #21066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
noencke
approved these changes
May 14, 2024
packages/dds/tree/src/feature-libraries/modular-schema/genericFieldKindFormat.ts
Outdated
Show resolved
Hide resolved
kekachmar
pushed a commit
to kekachmar/FluidFramework
that referenced
this pull request
May 21, 2024
…icrosoft#21066) In preparation for updating the package to use our recommended base eslint config, this PR enabled the `explicit-return-types` rule in the package (excluding test code) and fixes violations (while disabling the rule in select cases for functions that intentionally derive their return type from other functions/libraries). AB#6983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for updating the package to use our recommended base eslint config, this PR enabled the
explicit-return-typesrule in the package (excluding test code) and fixes violations (while disabling the rule in select cases for functions that intentionally derive their return type from other functions/libraries).AB#6983