Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump server deps to prerelease version on client #21044

Closed
wants to merge 1 commit into from

Conversation

WillieHabi
Copy link
Contributor

Bumping server dependencies in the client release group to access new targeted signal capabilities on the client side.

@github-actions github-actions bot added area: dds: propertydds base: main PRs targeted against main branch area: driver Driver related issues area: examples Changes that focus on our examples area: loader Loader related issues area: odsp-driver area: tests Tests to add, test infrastructure improvements, etc dependencies Pull requests that update a dependency file labels May 10, 2024
@WillieHabi WillieHabi requested a review from jason-ha May 10, 2024 16:12
Comment on lines +17921 to +17929
dev: true

/@fluidframework/protocol-base/5.0.0-262463:
resolution: {integrity: sha512-DxOqSucs2jtVddp5jVc5EOzwCCi35WuA8SpvFT94Z/ESrb8JpHhK55OGgK4AVsz7QavuWlg0/B9FQjfHclhOhw==}
dependencies:
'@fluidframework/common-utils': 3.1.0
'@fluidframework/gitresources': 5.0.0-262463
'@fluidframework/protocol-definitions': 3.2.0
events_pkg: /events/3.3.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming a prerelease dependency is okay, you will need to figure out the duplications that are now appearing. What is using older 4.x and is that okay?

@msfluid-bot
Copy link
Collaborator

msfluid-bot commented May 10, 2024

@fluid-example/bundle-size-tests: +249 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 454.95 KB 454.95 KB No change
azureClient.js 552.06 KB 552.14 KB +83 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 258.8 KB 258.8 KB No change
fluidFramework.js 357.54 KB 357.54 KB No change
loader.js 132.78 KB 132.86 KB +83 Bytes
map.js 41.45 KB 41.45 KB No change
matrix.js 143.67 KB 143.67 KB No change
odspClient.js 520.6 KB 520.68 KB +83 Bytes
odspDriver.js 97.29 KB 97.29 KB No change
odspPrefetchSnapshot.js 42.15 KB 42.15 KB No change
sharedString.js 160.19 KB 160.19 KB No change
sharedTree.js 357.53 KB 357.53 KB No change
Total Size 3.2 MB 3.2 MB +249 Bytes

Baseline commit: 6751230

Generated by 🚫 dangerJS against e61eac6

@tylerbutler
Copy link
Member

Server releases are not trivial and should always be done by release drivers. Please work with them to make sure this is done correctly. @DLehenbauer @anthony-murphy FYI.

@WillieHabi WillieHabi closed this May 13, 2024
@WillieHabi
Copy link
Contributor Author

Server releases are not trivial and should always be done by release drivers. Please work with them to make sure this is done correctly. @DLehenbauer @anthony-murphy FYI.

Will contact FF release engineer so this is done properly.

@WillieHabi WillieHabi reopened this May 14, 2024
@WillieHabi WillieHabi closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: propertydds area: driver Driver related issues area: examples Changes that focus on our examples area: loader Loader related issues area: odsp-driver area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants