Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(odsp-client): Change scope from fluid-experimental to fluidframework #21024

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sonalideshpandemsft
Copy link
Contributor

@sonalideshpandemsft sonalideshpandemsft commented May 8, 2024

This PR updates the scope for odsp-client package moving it from fluid-experimental to fluidframework.

AB#7988

@github-actions github-actions bot added public api change Changes to a public API base: main PRs targeted against main branch labels May 8, 2024
@ChumpChief
Copy link
Contributor

For visibility, we're currently looking at resolving test pipeline issues before merging this scope change.

@@ -133,7 +133,6 @@
"typescript": "~5.1.6"
},
"typeValidation": {
"disabled": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work until a version has been released with the new name. If you want to enable type tests now you'll need to manually add the previous version with the old name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's defer enabling until after a version has been released then, thanks for the heads up Tyler!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled typetests. thanks Tyler! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants