-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tree): Schema validation #21011
Conversation
da3c1c5
to
9d883a6
Compare
⯅ @fluid-example/bundle-size-tests: +3.8 KB
Baseline commit: 6abe291 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - approving for what I see. I think you mentioned that you're going to make some changes, so feel free to re-request review when necessary.
@noencke new changes in; basically moved the new |
Description
Builds on top of #20904, to enable content being inserted into a shared tree to be validated against the stored schema of the tree.
Reviewer Guidance
The review process is outlined on this wiki page.
I first tried putting the flag that defines if schema validation should happen or not just in TreeConfiguration but some code paths didn't seem to have good access to it. It felt natural to make it part of the policy.