Simplify webpack-fluid-loader's webpack config #21004
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify webpack-fluid-loader's webpack config. This modernizes it based off of the content in examples/utils/webpack-fluid-loader/src/defaultWebpackConfig.ts. No longer needed workarounds have been removed.
Reviewer Guidance
The review process is outlined on this wiki page.
Its unclear to me what this config is used for: It's hard coded into "development" and the package is in
@fluid-exampleso I suspect its either just for testing, or just used by examples. Given that the bundle is generated into "dist", it seems like its only available in one of the two build configurations, which also makes me things its not actually used for anything other that testing if it can webpack without errors.