Fix rdkafka consumer hanging when disconnecting #13144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: server
hedasilv
approved these changes
Dec 1, 2022
hedasilv
reviewed
Dec 1, 2022
| ...this.consumerOptions.additionalOptions, | ||
| ...this.sslOptions, | ||
| }; | ||
|
|
||
| const consumer: kafkaTypes.KafkaConsumer = this.consumer = | ||
| consumer = this.consumer = |
There was a problem hiding this comment.
I think the build is failing because it says consumer.subscribe() in line 127 below and consumer.consume() could possibly be undefined
src/rdkafkaConsumer.ts:127:4 - error TS2532: Object is possibly 'undefined'.
hedasilv
approved these changes
Dec 1, 2022
| } | ||
|
|
||
| // eslint-disable-next-line prefer-const | ||
| let consumer: kafkaTypes.KafkaConsumer; |
There was a problem hiding this comment.
If we don't reassign this later, why not make it const instead of disabling the eslint rule?
There was a problem hiding this comment.
Because it needs to be declared ahead of time for use by the "rebalance_cb" property in the kafka consumer constructor options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
consumer.close()was hanging indefinitely when theoptimizedRebalanceconfig was enabled.The issue is the same as confluentinc/confluent-kafka-go#767
The
rebalancemethod needs to callconsumer.unassign()when closing. It was not doing this becausethis.consumerwas being set toundefinedbefore disconnecting.