Converted prefer-declare-function from TSLint to ESLint #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
requested review from
sandersn and
andrewbranch
as code owners
|
Bump @andrewbranch - is there any chance this & the other open TSLint->ESLint PRs be looked at soon, please? |
|
@JoshuaKGoldberg I work on these during my DT week but I don't think anybody else is. When everybody gets back I'll ask others to take time as well. |
sandersn
requested changes
Dec 28, 2022
| { | ||
| code: ` | ||
| namespace N { | ||
| export const example: () => void; |
There was a problem hiding this comment.
also needs to forbid const example: () => void, without the export
| create(context) { | ||
| return { | ||
| // eslint-disable-next-line @typescript-eslint/naming-convention | ||
| "ExportNamedDeclaration > VariableDeclaration > VariableDeclarator"(node: TSESTree.VariableDeclarator) { |
There was a problem hiding this comment.
the type doesn't need to be exported to be an error.
sandersn
reviewed
Dec 29, 2022
sandersn
approved these changes
Dec 30, 2022
|
I'll ship this tomorrow so I can create my fixup PR on DT right after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues the work from #489.