Add support for PathBase in Aspnetcore #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
cijothomas
approved these changes
Aug 10, 2020
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
I've noticed that currently, when using telemetry in AspNetCore, Request.PathBase is not used to log the requested uri (see PathBase usage here)
I've changed the HttpRequestExtensions.GetUri method to add it to the concat and added a test accordingly.
Regards,