Added a container id provider that supports getting info from mountinfo #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pkoelbl This is the PR to implement getting container id from mountinfo. Let me know if you are willing to share any early feedback. |
|
Looks good. Let me know when you have a beta nuget |
karolz-ms
reviewed
May 31, 2022
src/ApplicationInsights.Kubernetes/ContainerIdProviders/MountInfoContainerIdProvider.cs
Outdated
Show resolved
Hide resolved
src/ApplicationInsights.Kubernetes/ContainerIdProviders/MountInfoContainerIdProvider.cs
Outdated
Show resolved
Hide resolved
src/ApplicationInsights.Kubernetes/ContainerIdProviders/MountInfoContainerIdProvider.cs
Outdated
Show resolved
Hide resolved
|
Hey @karolz-ms Thanks so much for the review. I really appreciated that you bring containerd into our attention. I've given it another iteration, mind take another review? Alone with the implementation, I also put up a draft for a wiki of the design we discussed, mind also give it a quick peak: https://github.com/microsoft/ApplicationInsights-Kubernetes/wiki/Design---ContainerIdProviders-%5BDRAFT%5D when you have time? Thanks. |
karolz-ms
approved these changes
Jun 6, 2022
...pplicationInsights.Kubernetes/ContainerIdProviders/EnvironmentVariableContainerIdProvider.cs
Show resolved
Hide resolved
…v2-container-provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #246
Looks like
/proc/self/mountinfois a relative reliable spot to getting container id that supports cgroupv2.