Maven test dependencies outside of rocker #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moreover, it uses mockk version from the BOM for Maven Projects. it is published by micronaut test.
sdelamo
force-pushed
the
test-outside-of-rocker
branch
from
fc4bb98
to
0fe134e
Compare
alvarosanchez
requested changes
Sep 19, 2022
starter-core/src/main/java/io/micronaut/starter/feature/build/maven/templates/pom.rocker.raw
Outdated
Show resolved
Hide resolved
alvarosanchez
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
However, it does not use mockk version from the BOM for Maven Projects because that version does not work with Maven.
Mockk has upgraded to use Kotlin Multiplatform and does not work with Maven.
I think we should add
io.mockk:mockk-jvmto micronaut-test. Because of that, I think we should keep the same versions we used to have for now.