Introducing OKE #534
Draft
Introducing OKE #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n0tl3ss
force-pushed
the
feature/workflow1
branch
2 times, most recently
from
fecdc56
to
3632555
Compare
n0tl3ss
force-pushed
the
feature/workflow1
branch
from
c93bc82
to
82acb32
Compare
n0tl3ss
force-pushed
the
feature/workflow1
branch
from
82acb32
to
71fdbd8
Compare
alvarosanchez
requested changes
Mar 13, 2023
.github/workflows/graalvm.yml
Outdated
| GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }} | ||
| GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GRADLE_ENTERPRISE_CACHE_USERNAME }} | ||
| GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GRADLE_ENTERPRISE_CACHE_PASSWORD }} | ||
| GIT_COMMIT_HASH: ${{ github.sha }} | ||
| OCI_REGION: ${{ secrets.OCI_REGION }} |
There was a problem hiding this comment.
Can we change the action to use OCI_CLI_REGION instead?
| @@ -16,6 +16,12 @@ on: | |||
| jobs: | |||
| build: | |||
| if: github.repository != 'micronaut-projects/micronaut-project-template' | |||
| env: | |||
There was a problem hiding this comment.
FYI this workflow is being removed since we are running coverage in the main Gradle workflow. See micronaut-projects/micronaut-project-template#342
Comment on lines
42
to
45
| String tagName = "latest" | ||
| if (StringUtils.isNotEmpty(imageTag)) { | ||
| tagName = imageTag | ||
| } |
There was a problem hiding this comment.
Suggested change
| String tagName = "latest" | |
| if (StringUtils.isNotEmpty(imageTag)) { | |
| tagName = imageTag | |
| } | |
| String tagName = imageTag ?: "latest" |
Comment on lines
37
to
50
| def imageName = "micronaut-kubernetes-operator-example" | ||
| def tagName = "latest" | ||
|
|
||
| if (StringUtils.isNotEmpty(imagePrefix.orElse(null))) { | ||
| imageName = imagePrefix.get() + imageName | ||
| } | ||
|
|
||
| if (StringUtils.isNotEmpty(imageTag.orElse(null))) { | ||
| tagName = imageTag.get() | ||
| } | ||
|
|
||
| imageName = imageName + ":" + tagName | ||
|
|
||
| log.info("Image name: ${imageName}") |
There was a problem hiding this comment.
This could be reused into a method in KubernetesSpecification
n0tl3ss
force-pushed
the
feature/workflow1
branch
from
b6e7447
to
c35909e
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves CI/CD tests to use OKE cluster instead of Kind. With vcluster we are creating virtual cluster for every test run inside Oracle Kubernetes Engine. Docker images that produced during build process are specially tagged by hash of commit and java version. Then images are pushed to Oracle Container Registry. Every test run will create virtual cluster and pick docker image based on the tag described above.
The old setup files are also left because for local development it is much easier to use kind instead of OKE.