Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: version to 4.0.0 Micronaut 4.0.0-SNAPSHOT githubCoreBranch=4.0.x #422

Merged
merged 10 commits into from Sep 13, 2022
Merged

ci: version to 4.0.0 Micronaut 4.0.0-SNAPSHOT githubCoreBranch=4.0.x #422

merged 10 commits into from Sep 13, 2022

Conversation

wetted
Copy link
Contributor

@wetted wetted commented Aug 16, 2022 •
edited

closes #395
closes #399
closes #398
closes #414

satisfies task in micronaut-projects/micronaut-core#7720

@wetted wetted marked this pull request as draft August 16, 2022 18:52
@wetted wetted self-assigned this Aug 16, 2022
sdelamo
sdelamo requested changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it fail?

gradle.properties Outdated Show resolved Hide resolved
@wetted
Copy link
Contributor Author

wetted commented Sep 7, 2022

Why does it fail?

@sdelamo This has several issues I need to address for the kotlin/ktor upgrades. It's a WIP.

@wetted
fixing broken test
a3c5cad
@wetted
bump Micronaut Test to 3.5.0
b44ad6a
@wetted
Merge remote-tracking branch 'origin/4.0.x' into prepare-for-micronaut4
9cb8884 
# Conflicts:
#	examples/greeting/build.gradle
#	gradle.properties
#	kotlin-extension-functions/src/test/kotlin/io/micronaut/kotlin/inject/QualifiersExtensionsTest.kt
#	settings.gradle
@wetted
Copy link
Contributor Author

wetted commented Sep 8, 2022

#403 and #413 to upgrade ktor are a bit more involved with breaking changes to dependency coordinates, package names and API. I will work this on a separate PR.

@wetted wetted marked this pull request as ready for review September 8, 2022 15:22
@wetted wetted requested a review from sdelamo September 8, 2022 15:22
@wetted wetted marked this pull request as draft September 8, 2022 15:40
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wetted wetted marked this pull request as ready for review September 8, 2022 16:07
@sdelamo sdelamo merged commit b218552 into 4.0.x Sep 13, 2022
@sdelamo sdelamo deleted the prepare-for-micronaut4 branch September 13, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdelamo sdelamo sdelamo approved these changes

@timyates timyates Awaiting requested review from timyates

Assignees

@wetted wetted

Labels
None yet
Projects
No open projects
4.0.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wetted @sdelamo