Added lost slf4j, logback, log4j versions #8968
Conversation
|
I think they should be in https://github.com/micronaut-projects/micronaut-platform not in core |
|
They should probably neither be in |
| @@ -207,7 +219,7 @@ kotlinx-coroutines-rx2 = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-rx | |||
| kotlinx-coroutines-slf4j = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-slf4j", version.ref = "kotlin-coroutines" } | |||
| kotlinx-coroutines-reactor = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-reactor", version.ref = "kotlin-coroutines" } | |||
|
|
|||
| log4j = { module = "org.apache.logging.log4j:log4j-core", version.ref = "log4j" } | |||
| log4j = { module = "org.apache.logging.log4j:log4j-core", version.ref = "managed-log4j" } | |||
There was a problem hiding this comment.
❌ This should be managed too, right?
There was a problem hiding this comment.
@melix Yes, it's necessary. For example, if you want to use slf4j in your project in conjunction with micronaut-elasticsearch - for this you will need the 'org.apache.logging.log4j:log4j-to-slf4j:2.20.0' library and at the moment you will have to duplicate the log4j version in your project because this module is not in the bom file. We already discussed this here: #8138 . And now everything works fine with version 3.7.x. But these changes are lost in version 4.x
There was a problem hiding this comment.
@altro3 we moved versions outside of core intentionally in 4.0.x. I think micronaut-logging is probably the way to go.
There was a problem hiding this comment.
@sdelamo good solution! But where is project micronaut-logging? :-)
|
Closed via #8986 |
Lost changes from micronaut 3.8 (see #8138)