Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump native-maven-plugin to 0.9.19 #8502

Merged
merged 1 commit into from Dec 20, 2022
Merged

build: bump native-maven-plugin to 0.9.19 #8502

merged 1 commit into from Dec 20, 2022

Conversation

sdelamo
Copy link
Collaborator

@sdelamo sdelamo commented Dec 20, 2022

@sdelamo sdelamo requested a review from melix December 20, 2022 00:10
@sdelamo sdelamo added the type: dependency-upgrade Upgrade a dependency label Dec 20, 2022
@sdelamo sdelamo added this to the 3.8.0 milestone Dec 20, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alvarosanchez
Copy link
Member

alvarosanchez commented Dec 20, 2022

@melix despite #8399 this is still not being picked up by Renovate. I checked the Dependency Dashboard but it's not rate-limited.

I noticed #8370, but that's something else.

@melix
Copy link
Contributor

melix commented Dec 20, 2022

@alvarosanchez it is the same thing: our libs.versions.toml only contains a version for the plugin. There are no GAV coordinates associated with it, so there's no way renovate can figure out it has to upgrade it. If we want automatic upgrade we must add a dummy entry in the [libraries] section with the coordinates of that library.

@alvarosanchez
Copy link
Member

@melix
Copy link
Contributor

melix commented Dec 20, 2022

Right, but it's not on the main branch yet: https://github.com/micronaut-projects/micronaut-core/blob/4.0.x/gradle/libs.versions.toml

@alvarosanchez
Copy link
Member

Aaaaaah ok, I keep forgetting that 4.0.x is the default branch.

Then we are (will be?) good to go.

@sdelamo sdelamo merged commit dbdfbe9 into 3.8.x Dec 20, 2022
@sdelamo sdelamo deleted the sdelamo-patch-5 branch December 20, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade Upgrade a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants