Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overload DELETE method for URI object #8486

Merged
merged 1 commit into from Dec 16, 2022
Merged

Overload DELETE method for URI object #8486

merged 1 commit into from Dec 16, 2022

Conversation

wetted
Copy link
Member

@wetted wetted commented Dec 14, 2022

closes #8483

@wetted wetted requested a review from sdelamo December 14, 2022 16:52
@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@wetted
Copy link
Member Author

wetted commented Dec 14, 2022

SonarCloud fails because it doesn't like a method named in uppercase, i.e. DELETE() but we're already matching names/case of HTTP verbs.

@sdelamo sdelamo merged commit 04084ae into 3.8.x Dec 16, 2022
@sdelamo sdelamo deleted the overload_DELETE_verb branch December 16, 2022 12:01
@wetted wetted linked an issue Dec 19, 2022 that may be closed by this pull request
Add HttpRequest::DELETE(URI) method #8483
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdelamo sdelamo sdelamo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add HttpRequest::DELETE(URI) method
2 participants
@wetted @sdelamo