Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: CorsFilter #8474

Merged
merged 4 commits into from Dec 12, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -0,0 +1,19 @@
package io.micronaut.http.server.netty.cors

import io.micronaut.context.ApplicationContext
import io.micronaut.http.server.cors.CorsFilter
import spock.lang.AutoCleanup
import spock.lang.Shared
import spock.lang.Specification

class CorsFilterEnabledSpec extends Specification {

@AutoCleanup
@Shared
ApplicationContext applicationContext = ApplicationContext.run()

void "CorsFilter is not enabled by default"() {
expect:
!applicationContext.containsBean(CorsFilter)
}
}
Expand Up @@ -16,7 +16,6 @@
package io.micronaut.http.server.netty.cors

import io.micronaut.context.ApplicationContext
import io.micronaut.core.annotation.Nullable
import io.micronaut.core.async.publisher.Publishers
import io.micronaut.core.util.StringUtils
import io.micronaut.http.*
Expand All @@ -26,7 +25,6 @@ import io.micronaut.http.filter.ServerFilterChain
import io.micronaut.http.server.HttpServerConfiguration
import io.micronaut.http.server.cors.CorsFilter
import io.micronaut.http.server.cors.CorsOriginConfiguration
import io.micronaut.http.server.util.HttpHostResolver
import io.micronaut.runtime.server.EmbeddedServer
import io.micronaut.web.router.RouteMatch
import io.micronaut.web.router.Router
Expand Down
@@ -0,0 +1,19 @@
package io.micronaut.http.server.netty.cors

import io.micronaut.context.ApplicationContext
import io.micronaut.http.server.cors.CorsOriginConverter
import spock.lang.AutoCleanup
import spock.lang.Shared
import spock.lang.Specification

class CorsOriginConverterEnabledSpec extends Specification {

@AutoCleanup
@Shared
ApplicationContext applicationContext = ApplicationContext.run()

void "CorsOriginConverter is not enabled by default"() {
expect:
!applicationContext.containsBean(CorsOriginConverter)
}
}