test: refactor CorsFilterSpec as a black box #8473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors the CORS filter tests to verify its behavior from the outside, and it does not rely on calling the internal methods.
|
Kudos, SonarCloud Quality Gate passed! |
timyates
approved these changes
Dec 9, 2022
yawkat
approved these changes
Dec 9, 2022
| request.getHeaders() >> headers | ||
| def config = new HttpServerConfiguration.CorsConfiguration() | ||
| String origin = 'http://www.foo.com' | ||
| HttpHeaders headers = Stub(HttpHeaders) { |
There was a problem hiding this comment.
do we need a mock here, or is there an implementation we can use?
There was a problem hiding this comment.
In other places, we use MockHttpHeaders but I think in this test the Stub is ok.
yawkat
added a commit
that referenced
this pull request
Dec 10, 2022
micronaut-function-aws-api-proxy requests include the host in getUri. This leads to no match with findAny. This causes the AVAILABLE_HTTP_METHODS to be empty, which causes a test failure with CorsFilter in the aws module. Unfortunately I can't test this using CorsFilterSpec in this repo, because CorsFilterSpec calls findAny directly instead of using the findRouteMatch code path. There is also a PR for refactoring CorsFilterSpec (#8473) but it does not get rid of the mocking either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the
CorsFilterSpecto test it as a black box instead of testing internal methods such ashandleRequest. I will send a separate PR to refactorCorsFilter.