Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route processing refactor #8463

Merged
merged 34 commits into from
Dec 14, 2022
Merged

Route processing refactor #8463

merged 34 commits into from
Dec 14, 2022

Commits on Dec 1, 2022

  1. factor out some RoutingInBoundHandler code, new HttpData implementation

    @yawkat
    yawkat committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    3308f4b View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. remove HttpDataReference

    @yawkat
    yawkat committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    ecee25a View commit details
    Browse the repository at this point in the history

  2. docs for MicronautHttpData

    @yawkat
    yawkat committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    bbccb79 View commit details
    Browse the repository at this point in the history

  3. Merge branch '4.0.x' into route-refactor

    @yawkat
    yawkat committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    19870a7 View commit details
    Browse the repository at this point in the history

  4. remove one Mono

    @yawkat
    yawkat committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    e3a418f View commit details
    Browse the repository at this point in the history

  5. fix demand from downstream publishers

    @yawkat
    yawkat committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    ac3ec90 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. refactor HttpContentProcessor to work independent of reactive

    @yawkat
    yawkat committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    ed495c7 View commit details
    Browse the repository at this point in the history

  2. remove one reactive step in RouteRunner :)

    @yawkat
    yawkat committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    0ca937e View commit details
    Browse the repository at this point in the history

  3. move some more code

    @yawkat
    yawkat committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    dc610ff View commit details
    Browse the repository at this point in the history

  4. move exception handler also

    @yawkat
    yawkat committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    be23672 View commit details
    Browse the repository at this point in the history

  5. make HttpContentProcessor work on an output parameter instead

    @yawkat
    yawkat committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    da4ddda View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. fix context propagation from filters to controller

    @yawkat
    yawkat committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    bc825a2 View commit details
    Browse the repository at this point in the history

  2. "fix" test for reactive filters

    @yawkat
    yawkat committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    20ac0ef View commit details
    Browse the repository at this point in the history

  3. document BaseRouteCompleter

    @yawkat
    yawkat committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    87a9aec View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. move most RouteExecutor code to a new RequestLifecycle class

    @yawkat
    yawkat committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    7bbbfca View commit details
    Browse the repository at this point in the history

  2. move websocket handler to RequestLifecycle as well

    @yawkat
    yawkat committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    c422f7c View commit details
    Browse the repository at this point in the history

  3. checkstyle

    @yawkat
    yawkat committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    35ebe55 View commit details
    Browse the repository at this point in the history

  4. this test is flaky

    @yawkat
    yawkat committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    2715e87 View commit details
    Browse the repository at this point in the history

  5. make HttpContentProcessor an interface again

    @yawkat
    yawkat committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    db6afd5 View commit details
    Browse the repository at this point in the history

  6. sonar

    @yawkat
    yawkat committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    7b4e23f View commit details
    Browse the repository at this point in the history

  7. sonar

    @yawkat
    yawkat committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    68cd933 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. address review comments

    @yawkat
    yawkat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    1cfdfe6 View commit details
    Browse the repository at this point in the history

  2. address review comments

    @yawkat
    yawkat committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    bbfd57b View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2022

  1. this is wrong after all

    @yawkat
    yawkat committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    d5bafc3 View commit details
    Browse the repository at this point in the history

  2. Fix findRouteMatch for aws requests 

    micronaut-function-aws-api-proxy requests include the host in getUri. This leads to no match with findAny. This causes the AVAILABLE_HTTP_METHODS to be empty, which causes a test failure with CorsFilter in the aws module.

Unfortunately I can't test this using CorsFilterSpec in this repo, because CorsFilterSpec calls findAny directly instead of using the findRouteMatch code path. There is also a PR for refactoring CorsFilterSpec (#8473) but it does not get rid of the mocking either.
    @yawkat
    yawkat committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    686de0f View commit details
    Browse the repository at this point in the history

  3. Move away from getUri.toString in more places

    @yawkat
    yawkat committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    4a040af View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. inline handleNormal0

    @yawkat
    yawkat committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    a5aedcd View commit details
    Browse the repository at this point in the history

  2. improve subscriber error handling

    @yawkat
    yawkat committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    fa2d56e View commit details
    Browse the repository at this point in the history

  3. inline RIB.find

    @yawkat
    yawkat committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    23cf02b View commit details
    Browse the repository at this point in the history

  4. simplify instanceof

    @yawkat
    yawkat committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    c4651fa View commit details
    Browse the repository at this point in the history

  5. replace HttpContentProcessorAsReactive* with reactor

    @yawkat
    yawkat committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    beb53f3 View commit details
    Browse the repository at this point in the history

  6. in MultipartBodyArgumentBinder, always assume HttpData

    @yawkat
    yawkat committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    c2f185c View commit details
    Browse the repository at this point in the history

  7. sonar

    @yawkat
    yawkat committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    7b0b240 View commit details
    Browse the repository at this point in the history

  8. checkstyle

    @yawkat
    yawkat committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    31ea9da View commit details
    Browse the repository at this point in the history