Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support records for @RequestBean #8420

Merged
merged 2 commits into from Dec 2, 2022
Merged

Support records for @RequestBean #8420

merged 2 commits into from Dec 2, 2022

Conversation

yawkat
Copy link
Member

@yawkat yawkat commented Nov 24, 2022

@dstepanov the MissingParameterRule patch is a bit weird, the properties returned by getBeanProperties don't include annotations. Should they?

Fixes #8295

@dstepanov the MissingParameterRule patch is a bit weird, the properties returned by getBeanProperties don't include annotations. Should they?

Fixes #8295
@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

56.2% 56.2% Coverage
0.0% 0.0% Duplication

@dstepanov
Copy link
Contributor

I’m not familiar with the behavioral before v4

@yawkat
Copy link
Member Author

yawkat commented Nov 24, 2022

@dstepanov it's the same with 4.0, AstBeanPropertiesUtils only considers field and method

@graemerocher graemerocher merged commit 4fddaa9 into 3.8.x Dec 2, 2022
@graemerocher graemerocher deleted the request-bean-record branch December 2, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants