Ensure Logback is refreshed before application starts

[driverpt]

Attempts to fix #8139

[graemerocher]

I believe this will be fixed by #8235 which moves logback to runtime intiailization

[driverpt]

@graemerocher , with this modification you can keep build time initialization, it just resets all internal logback caches when Micronaut Inits.

The issue is that Logback is initialized when JVM Starts. The LoggerContext#reset only resets it's internal caches, so we can take advantage of Logback being previously initialized at build time. Won't improve much in terms of performance, but will add something

[graemerocher]

This seems safe enough to target 3.8.x branch, can you do that?

[driverpt]

Done. Can you unblock the CI? I suspect that the test will fail

[graemerocher]

not sure why it is blocked 🤔

[graemerocher]

@n0tl3ss this might help with the logging issue for AWS/OCI

[driverpt]

Is there any ETA on this?

[graemerocher]

waiting for feedback from @n0tl3ss

[driverpt]

@n0tl3ss , can you help out here? This is currently the only blocker we have to go live with Micronaut

[graemerocher]

@driverpt from the looks of the change it seems like you could wire this into your existing application without a new version of Micronaut necessarily blocking you?

[n0tl3ss]

Hi, @driverpt. I created copy of this pull request: #8263.

[driverpt]

@n0tl3ss , fixed checkstyle issue

[n0tl3ss]

@n0tl3ss this might help with the logging issue for AWS/OCI

I tried but without success

[graemerocher]

please fix the broken tests

[driverpt]

I will, but at the end of the day

[driverpt]

@graemerocher @n0tl3ss , GitHub Workflow needs a maintainers approval to run

[driverpt]

@graemerocher @n0tl3ss , please review this part. I need your opinion on this one

[n0tl3ss]

I think something like

    @Override
    public void refresh() {
        getLoggerContext().reset();
        try {
            new ContextInitializer(getLoggerContext()).autoConfig();
        } catch (JoranException e) {
            throw new LoggingSystemException("Error while refreshing Logback", e);
        }
    }

would do a trick.

[n0tl3ss]

There is io.micronaut.management.endpoint.loggers.impl.LogbackLoggingSystem class that might replace io.micronaut.logging.impl.LogbackLoggingSystem. Should it also override refresh() method?

[n0tl3ss]

I think something like

    @Override
    public void refresh() {
        getLoggerContext().reset();
        try {
            new ContextInitializer(getLoggerContext()).autoConfig();
        } catch (JoranException e) {
            throw new LoggingSystemException("Error while refreshing Logback", e);
        }
    }

would do a trick.

[driverpt]

There is io.micronaut.management.endpoint.loggers.impl.LogbackLoggingSystem class that might replace io.micronaut.logging.impl.LogbackLoggingSystem. Should it also override refresh() method?

I'm not a fan of copy + paste the same code in 2 classes. What do you suggest?

[driverpt]

@n0tl3ss , were you able to get this "Fix" running smoothly?

I've been testing this and it seems like after I call loggerContext.reset() that it goes completely silent.

[driverpt]

@n0tl3ss , can you please test if the logging works in AWS/OCI ?

Thanks

[driverpt]

UPDATE: This seems to work in AWS Environment. But the downside is that we will need to add a reflect-config.json for all Logback components that we are using.

E.g.: In my case, the logstash-logback-encoder. But seems to be working with the simple Console Appender

[driverpt]

@graemerocher @n0tl3ss , Checkstyle is failing due to NettyServer.java issue

[graemerocher]

Thanks for the contribution!