feature: Support validation groups with @Validated
#7265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-wise
force-pushed
the
validation-groups
branch
3 times, most recently
from
3623dd8
to
6719795
Compare
|
Yes please target 3.5.x |
ok. When will 3.4.x be merged into 3.5.x? This PR depends on the fix that was just merged to 3.4.x. As soon as that merges I'll rebase. |
kevin-wise
force-pushed
the
validation-groups
branch
from
6719795
to
4f4bf33
Compare
|
I have merged up. Thanks. |
kevin-wise
force-pushed
the
validation-groups
branch
from
4f4bf33
to
d47fef1
Compare
|
Rebased and base branch updated. Should be ready for review |
kevin-wise
force-pushed
the
validation-groups
branch
from
d47fef1
to
02b2905
Compare
|
@graemerocher could I get a review? Would like to get this into 3.5.x if possible |
graemerocher
requested changes
May 10, 2022
validation/src/main/java/io/micronaut/validation/ValidatingInterceptor.java
Outdated
Show resolved
Hide resolved
kevin-wise
force-pushed
the
validation-groups
branch
from
02b2905
to
fd07062
Compare
|
updated as requested, and rebased. No problem on the delay, I understand. Just didn't know what to expect since I'm new to this project. I hope tagging you was ok. |
kevin-wise
force-pushed
the
validation-groups
branch
from
fd07062
to
02c8e41
Compare
|
tagging me is good, sometimes I need reminders :) |
graemerocher
approved these changes
May 10, 2022
kevin-wise
force-pushed
the
validation-groups
branch
2 times, most recently
from
a48fa2f
to
96354e5
Compare
kevin-wise
force-pushed
the
validation-groups
branch
from
96354e5
to
39d8863
Compare
|
sorry for the additional force pushes. Just fixing the format on the javadoc to match convention. All done now, promise :) |
|
@graemerocher does this need another review? Or can it get merged |
sdelamo
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable specifying the validation groups to be used with
@Validated. For example,@Validated(groups = Group1.class). Should this be based on 3.5.x, since it's a new feature?Also, this is my first time trying to update the documentation. Hopefully I got the syntax right.