Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release FileUpload, not the wrapped buffer, in NettyCompletedFileUpload #6759

Merged
merged 1 commit into from Jan 18, 2022
Merged

Release FileUpload, not the wrapped buffer, in NettyCompletedFileUpload #6759

merged 1 commit into from Jan 18, 2022

Commits on Jan 14, 2022

  1. Release FileUpload, not the wrapped buffer, in NettyCompletedFileUpload 

    When `controlRelease` is set, `NettyCompletedFileUpload` will `retain()` the `FileUpload` instance, however before this patch, it would `release` the `FileUpload.getByteBuf()`, not the `FileUpload` itself.

This bug can be reproduced using `UploadSpec#test upload CompletedFileUpload object`, but unfortunately does not yield a test failure, only a log message.

Fixes #6710
    @yawkat
    yawkat committed Jan 14, 2022
    Copy the full SHA
    d0050a6 View commit details
    Browse the repository at this point in the history