Fix HTTP/2 304 responses for files don't associate the correct stream ID #6752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graemerocher
changed the title
- use common method in NettyStreamedCustomizableResponseType too
yawkat
approved these changes
Jan 13, 2022
|
@graemerocher I also changed NettyStreamedCustomizableResponseType to use the new method |
|
@jameskleeh could you prioritize merging this, would like to get a snapshot for external testing |
yawkat
added a commit
that referenced
this pull request
Jan 21, 2022
… ID (#6752) * Fix HTTP 304 responses for files don't associate the correct stream ID * fix checkstyle / make final * checkstyle * - test case - use common method in NettyStreamedCustomizableResponseType too Co-authored-by: yawkat <jonas.konrad@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a 304 response is returned from
FileTypeHandlerand HTTP/2 is enabled the stream ID is not correctly associated between the request and the response resulting in some browsers (like Firefox) hanging and unable to handle the response