Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not apply filters when RouteExecutor decides not to handle an error #6745

Merged
merged 1 commit into from Jan 12, 2022
Merged

Do not apply filters when RouteExecutor decides not to handle an error #6745

merged 1 commit into from Jan 12, 2022

Commits on Jan 12, 2022

  1. Do not apply filters when RouteExecutor decides not to handle an error 

    For certain errors (`isIgnorable`), the `RouteExecutor` decides not to write a response for the error, and returns an empty flux. However, without this patch, the `RoutingInBoundHandler` would still apply filters. For example, the micronaut-security filter will check access permissions for the error request, even though those routes would never be executed anyway (`RouteExecutor` decided not to). That filter may then return a response.

This patch adds a short-circuit check for these 'closed connection' errors to `RoutingInBoundHandler`, and avoids running downstream processing altogether.

Fixes #6723
    @yawkat
    yawkat committed Jan 12, 2022
    Copy the full SHA
    f82947a View commit details
    Browse the repository at this point in the history