Modifies CompletableFutureContinuation to implement kotlin debug clas… #4544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s CoroutineStackFrame (#4438)
|
Closes #4438 |
|
This is an internal class? |
|
Nevermind read the comments on the linked issue |
|
Yeah James and I also thought at first this wasn't the way to go, but @qwwdfsad has informed us despite being in a package labeled internal, it is a public facing interface meant to be implemented: |
|
Hi @graemerocher, I see you fixed it in CompletableFutureContinuation but there is also another location that will need the same fix: kind regards, |
|
@timducheyne Appreciate the heads up! If you feel comfortable PRing that (or any other Continuation related classes we have) please feel free to submit them, otherwise I will try to get to it eventually Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s CoroutineStackFrame (#4438)