Improve ability to introspect bean context prior to start #10805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graemerocher
added
the
type: improvement
sdelamo
approved these changes
May 8, 2024
yawkat
approved these changes
May 13, 2024
graemerocher
force-pushed
the
configurable-application-context
branch
from
b4b7572
to
ca09c33
Compare
|
melix
approved these changes
May 15, 2024
There was a problem hiding this comment.
I have checked that these changes to not break AOT (without changing the code) and also after changing it to call the new configure() method.
Both work correctly 👍
Note that we were already using reflection to configure the context, so I could probably do something similar to support it right now (and probably remove the code for older Micronaut releases).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
InitializableBeanContextis problematic because it still creates context scoped beans and runs event listeners. We need a way to configure the context and allow it to be introspected prior to start so this deprecatesInitializableBeanContextand replaces it withConfigurableBeanContextandConfigurableApplicationContextinterfaces.These feature a
configure()method that loads the bean definitions and state needed to start the context but doesn't actually start it.The PR also adds logic to assert the context is running when resolving beans which was missing before and could lead to odd behaviour.