Fix file uploads beyond MMAP_SEGMENT_SIZE #10793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code path was not covered by tests and was broken. I also replaced the ReentrantLock by a NonReentrantLock that is based on a Semaphore. This is because there are some semantic checks in Chunk that might not work with a reentrant lock (e.g. repeated deallocate calls could lead to ref count errors). But this is unrelated to the bug. Fixes #10666
sdelamo
requested changes
May 3, 2024
http-server-netty/src/main/java/io/micronaut/http/server/netty/NonReentrantLock.java
Show resolved
Hide resolved
timyates
reviewed
May 3, 2024
graemerocher
approved these changes
May 3, 2024
…/NonReentrantLock.java Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
|
sdelamo
approved these changes
May 6, 2024
sdelamo
added a commit
that referenced
this pull request
May 9, 2024
* Fix file uploads beyond MMAP_SEGMENT_SIZE The code path was not covered by tests and was broken. I also replaced the ReentrantLock by a NonReentrantLock that is based on a Semaphore. This is because there are some semantic checks in Chunk that might not work with a reentrant lock (e.g. repeated deallocate calls could lead to ref count errors). But this is unrelated to the bug. Fixes #10666 * Update http-server-netty/src/main/java/io/micronaut/http/server/netty/NonReentrantLock.java Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com> * make badssl more resilient to timeouts * make badssl more resilient to timeouts --------- Co-authored-by: Sergio del Amo <sergio.delamo@softamo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code path was not covered by tests and was broken.
I also replaced the ReentrantLock by a NonReentrantLock that is based on a Semaphore. This is because there are some semantic checks in Chunk that might not work with a reentrant lock (e.g. repeated deallocate calls could lead to ref count errors). But this is unrelated to the bug.
Fixes #10666