Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force secure WebSocket connections to use http/1.1 #10754

Merged
merged 5 commits into from Apr 25, 2024
Merged

Force secure WebSocket connections to use http/1.1 #10754

merged 5 commits into from Apr 25, 2024

Commits on Apr 23, 2024

  1. Force secure WebSocket connections to use http/1.1 

    Connection manager is updated to use a separate SSLContext for
WebSocket connections that will only advertise http/1.1 in the list
of supported protocols in the ALPN section of the TLS handshake.

WebSocket is not currently supported over HTTP 2 connections, thus
if an HTTP 2 connection is established through ALPN, the subsequent
upgrade to the WebSocket protocol would fail.

This resolves #10744
    @jeremyg484
    jeremyg484 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a497838 View commit details
    Browse the repository at this point in the history

  2. Enable ALPN with Websocket and ensure SSLContext released.

    @jeremyg484
    jeremyg484 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    9997014 View commit details
    Browse the repository at this point in the history

  3. Lazily create websocket SSL context per connection

    @jeremyg484
    jeremyg484 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    31f68f8 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Use lazily intialized field for WebSocket SSL context.

    @jeremyg484
    jeremyg484 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    95e93dc View commit details
    Browse the repository at this point in the history

  2. Actually initialize in the initializer.

    @jeremyg484
    jeremyg484 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    04fd8e0 View commit details
    Browse the repository at this point in the history