Release FileUpload, not the wrapped buffer, in NettyCompletedFileUpload #6759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `controlRelease` is set, `NettyCompletedFileUpload` will `retain()` the `FileUpload` instance, however before this patch, it would `release` the `FileUpload.getByteBuf()`, not the `FileUpload` itself. This bug can be reproduced using `UploadSpec#test upload CompletedFileUpload object`, but unfortunately does not yield a test failure, only a log message. Fixes #6710
graemerocher
approved these changes
Jan 14, 2022
yawkat
added a commit
that referenced
this pull request
Jan 21, 2022
…ad (#6759) When `controlRelease` is set, `NettyCompletedFileUpload` will `retain()` the `FileUpload` instance, however before this patch, it would `release` the `FileUpload.getByteBuf()`, not the `FileUpload` itself. This bug can be reproduced using `UploadSpec#test upload CompletedFileUpload object`, but unfortunately does not yield a test failure, only a log message. Fixes #6710
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
controlReleaseis set,NettyCompletedFileUploadwillretain()theFileUploadinstance, however before this patch, it wouldreleasetheFileUpload.getByteBuf(), not theFileUploaditself.This bug can be reproduced using
UploadSpec#test upload CompletedFileUpload object, but unfortunately does not yield a test failure, only a log message.Fixes #6710