Skip to content

Commit

Permalink
this is wrong after all
Browse files Browse the repository at this point in the history
  • Loading branch information
yawkat committed Dec 10, 2022
1 parent bbfd57b commit d5bafc3
Showing 1 changed file with 3 additions and 3 deletions.
Expand Up @@ -144,9 +144,9 @@ private TypeConverter<FileUpload, CompletedFileUpload> fileUploadToCompletedFile
return Optional.empty();
}

// converter does not claim the input object, so we need to retain it here. it's
// released by NettyCompletedFileUpload.get*
return Optional.of(new NettyCompletedFileUpload(object.retain()));
// unlike NettyCompletedAttribute, NettyCompletedFileUpload does a `retain` on
// construct, so we don't need one here
return Optional.of(new NettyCompletedFileUpload(object));
} catch (Exception e) {
context.reject(e);
return Optional.empty();
Expand Down

0 comments on commit d5bafc3

Please sign in to comment.