Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix javadoc/sources publishing #220

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Fix javadoc/sources publishing #220

merged 1 commit into from
Oct 28, 2021

Conversation

melix
Copy link
Contributor

@melix melix commented Oct 28, 2021

This commit fixes javadocs and sources publishing for modules which use
shadow jar: in this case, the publishing mechanism does NOT use standard
Gradle publications. This caused the javadocs/sources to be ignored.

In order to check that publishing works properly, there's now the
possibility to override the default sonatype URIs, in order to verify
publication locally for example.

The following env vars/system properties were added:

  • allowInsecurePublishing: lets Gradle publish on a repository which
    doesn't use https. Useful for dry run deployments on local repos
  • SONATYPE_REPO_URI/sonatypeRepoUri : the URI of a sonatype server where
    to publish releases
  • SONATYPE_SNAPSHOT_REPO_URI/sonatypeSnapshotRepoUri: the URI of a nexus
    repository where to publish snapshots

This commit fixes javadocs and sources publishing for modules which use
shadow jar: in this case, the publishing mechanism does NOT use standard
Gradle publications. This caused the javadocs/sources to be ignored.

In order to check that publishing works properly, there's now the
possibility to override the default sonatype URIs, in order to verify
publication locally for example.

The following env vars/system properties were added:

- allowInsecurePublishing: lets Gradle publish on a repository which
doesn't use https. Useful for dry run deployments on local repos
- SONATYPE_REPO_URI/sonatypeRepoUri : the URI of a sonatype server where
to publish releases
- SONATYPE_SNAPSHOT_REPO_URI/sonatypeSnapshotRepoUri: the URI of a nexus
repository where to publish snapshots
@melix melix added the bug Something isn't working label Oct 28, 2021
@melix melix added this to the 4.2.4 milestone Oct 28, 2021
@melix melix self-assigned this Oct 28, 2021
@melix melix merged commit 6c4fb12 into master Oct 28, 2021
@melix melix deleted the cc/fix-javadocs-publishing branch October 28, 2021 08:24
melix added a commit to micronaut-projects/micronaut-core that referenced this pull request Oct 28, 2021
This will unblock the 3.1.2 release by making sure javadocs/sources
are published for all modules.

See micronaut-projects/micronaut-build#220
graemerocher pushed a commit to micronaut-projects/micronaut-core that referenced this pull request Oct 28, 2021
This will unblock the 3.1.2 release by making sure javadocs/sources
are published for all modules.

See micronaut-projects/micronaut-build#220
@ilopmar ilopmar mentioned this pull request Oct 28, 2021
GavrilovSV pushed a commit to GavrilovSV/micronaut-core that referenced this pull request Nov 6, 2021
This will unblock the 3.1.2 release by making sure javadocs/sources
are published for all modules.

See micronaut-projects/micronaut-build#220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant